Fix extended childcare entitlement expansion date (2025-09-01) #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the extended childcare entitlement hours parameter to reflect the correct policy implementation date of September 1, 2025 (not 2026-01-01). From September 2025, children aged 9 months to 2 years became eligible for 30 hours per week of free childcare (doubled from 15 hours), for eligible working parents in England. This fixes the calculation for 2025 scenarios where 2-year-olds were incorrectly receiving 15 hours instead of 30 hours. Fixes #1455 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The previous commit incorrectly updated test expectations for period 2025. When PolicyEngine evaluates for a full year period, it uses the parameter values at the start of the year (Jan 1, 2025), which is before the September 1, 2025 expansion to 30 hours for 2-year-olds. Changes: - Reverted test expectations for period 2025 to use 15 hours for 2-year-olds - Updated test names to clarify they test pre-expansion values - Added new tests for period 2026 to validate the 30-hour entitlement for 2-year-olds after the September 2025 expansion This ensures tests accurately reflect PolicyEngine's behavior while still validating that the parameter change is correct. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
|
Duplicate - original PR #1456 is now working |
MaxGhenis
added a commit
to MaxGhenis/policyengine-core
that referenced
this pull request
Jan 17, 2026
- Treat empty string same as None (fixes CI with missing secrets) - Check os.isatty(0) before prompting - return None in non-interactive environments instead of hanging on getpass - Update return type to str | None This fixes the 'httpx.LocalProtocolError: Illegal header value b'Bearer '' error that occurs when Dependabot PRs run without access to secrets. Closes PolicyEngine/policyengine-uk#1479 Co-Authored-By: Claude Opus 4.5 <[email protected]>
MaxGhenis
added a commit
to MaxGhenis/policyengine-core
that referenced
this pull request
Jan 17, 2026
- Treat empty string same as None (fixes CI with missing secrets) - Check os.isatty(0) before prompting - return None in non-interactive environments instead of hanging on getpass - Update return type to str | None This fixes the 'httpx.LocalProtocolError: Illegal header value b'Bearer '' error that occurs when Dependabot PRs run without access to secrets. Closes PolicyEngine/policyengine-uk#1479 Co-Authored-By: Claude Opus 4.5 <[email protected]>
MaxGhenis
added a commit
to PolicyEngine/policyengine-core
that referenced
this pull request
Jan 17, 2026
- Treat empty string same as None (fixes CI with missing secrets) - Check os.isatty(0) before prompting - return None in non-interactive environments instead of hanging on getpass - Update return type to str | None This fixes the 'httpx.LocalProtocolError: Illegal header value b'Bearer '' error that occurs when Dependabot PRs run without access to secrets. Closes PolicyEngine/policyengine-uk#1479 Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1456 to get CI running.
Changes:
Closes #1455